Skip to content

Conversation

@huhuanming
Copy link
Contributor

Summary

  • Add manufacturer-specific foldable device detection for 14 brands
  • Cache detection results in PreferenceManager with key 1k_fold
  • Extract device models from Google Play supported_devices.csv

Supported Manufacturers

Manufacturer Detection Method
Xiaomi Model list + system property persist.sys.muiltdisplay_type
Huawei Model list + device codes + com.huawei.hardware.sensor.posture
Vivo Model list + android.util.FtDeviceInfo API
OPPO Model list + OplusFeatureConfigManager
Samsung Model prefixes (SM-F9/SM-F7/SM-W70) + full model list
Google Model list (Pixel Fold series)
Motorola Model list (razr series)
ZTE/Nubia Model list
Tecno Model list (PHANTOM V series)
Infinix Model list (ZERO Flip)
Royole Model list
Honor Model list (Magic V series)
Vertu Model list (METAFLIP)

Key Changes

Test plan

  • Test on Samsung Galaxy Z Fold/Flip devices
  • Test on Xiaomi MIX Fold devices
  • Test on non-foldable devices (should return false)
  • Verify cache is saved to PreferenceManager

🤖 Generated with Claude Code

huhuanming and others added 6 commits January 12, 2026 02:15
Add comprehensive foldable device detection for Xiaomi, Huawei, Vivo,
OPPO, Samsung, Google, Motorola, and ZTE/Nubia devices using model
lists and manufacturer-specific APIs. Cache detection results in
PreferenceManager with key "1k_fold" to avoid repeated detection.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Add comprehensive foldable device models extracted from the Google Play
supported_devices.csv, including:
- Vivo X Fold5 (V2436A, V2429)
- ZTE Libero Flip, nubia Flip 2 5G
- Honor Magic V2/V3/V5/Vs series
- Vertu METAFLIP
- Tecno PHANTOM V Fold/Flip series
- Infinix ZERO Flip
- Royole VERTU Ayxta Fold 3
- Complete Samsung Galaxy Z Fold/Flip model numbers

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Change return type from non-existent Variant_NullType_RecordResult
to Promise<RecordResult?> to match HybridCloudKitModuleSpec interface.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Pin exact version (no caret prefix) across all subprojects:
- native-modules/*
- native-views/*
- example/react-native
- scripts/nitro/template
- scripts/nitro-view/template
- root package.json

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@socket-security
Copy link

socket-security bot commented Jan 29, 2026

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Addedreact-native-nitro-modules@​0.33.210010010095100

View full report

huhuanming and others added 6 commits January 29, 2026 11:02
Change return type from Variant_NullType_RecordResult to
Promise<RecordResult?> to match HybridCloudKitModuleSpec interface.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Update both iOS and Android CloudKitModule implementations to use
Variant_NullType_RecordResult instead of optional types, matching
the nitrogen 0.31.10 generated spec.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants